Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): duplication of deferred states #888

Merged
merged 5 commits into from
Mar 4, 2019
Merged

fix(store): duplication of deferred states #888

merged 5 commits into from
Mar 4, 2019

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

#883

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@splincode splincode requested review from markwhitfeld, arturovt and eranshmil and removed request for markwhitfeld March 2, 2019 21:21
markwhitfeld
markwhitfeld requested changes Mar 4, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the issues I have raised. I will commit an update to this branch to sort these out.

packages/store/src/internal/state-factory.ts Show resolved Hide resolved
packages/store/src/internal/state-factory.ts Outdated Show resolved Hide resolved
markwhitfeld
markwhitfeld approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to go now.

@splincode splincode merged commit 103604a into master Mar 4, 2019
@eranshmil eranshmil deleted the bugfix/lazy-states branch March 4, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@arturovt arturovt arturovt approved these changes

@eranshmil eranshmil Awaiting requested review from eranshmil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @markwhitfeld @arturovt