fix(logger): log group not closed on error

[eranshmil]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #817

What is the new behavior?

I added the error log in case the error raised is suppressed with a custom error handler after the logger ran.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[markwhitfeld]

Awesome work!
Is it possible to add a test for this?

[splincode]

@markwhitfeld yes of course
My custom logger
https://github.com/splincodewd/client-logger

Test for logger
https://github.com/splincodewd/client-logger/blob/master/src/plugins/console-group-api/console-group-api.spec.ts

[splincode]

https://github.com/splincodewd/client-logger/blob/master/src/utils/spec-helpers/converter.ts

[splincode]

I think we need to make testing tools. @ngxs/store/testing

[eranshmil]

Awesome work!
Is it possible to add a test for this?

Yeah, that's my next task in this matter, but I wanted to get this fix in the next version.

[markwhitfeld]

Agreed. I think that testing tools are high on the agenda for the next release.
@eranshmil are you going to get a chance to add the test?
Aiming for release tomorrow

[splincode]

@markwhitfeld I think you need to add it to the release, add tests later.

[eranshmil]

Agreed. I think that testing tools are high on the agenda for the next release.
@eranshmil are you going to get a chance to add the test?
Aiming for release tomorrow

I'm currently working on them, but not quite sure if I'll finish them until tomorrow.

[splincode]

@markwhitfeld Can we suspend release?

[splincode]

@markwhitfeld ping

[arturovt]

@markwhitfeld ping 🚀

[markwhitfeld]

LGTM. Sorry it took so long for me to get to this!