-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract createSelector function for public api #484
Conversation
8cc7ecc
to
a0b0b72
Compare
I think this is a good idea |
The integration tests failed in a strange way (looks like a server error): Rewrote commit and pushed again to get a rebuild going and got the same error: It works locally so I'm not sure what the issue is here. Looks like missing pollyfills or something |
Added more tests as part of this and now we have broken the 100 tests mark! |
cd5398c
to
bff6dea
Compare
bff6dea
to
4ff63a8
Compare
@markwhitfeld this is actually a bit different then I was thinking. still poking at it |
@deebloo what were you thinking? I'm interested in what other use cases for a createSelector that there may be |
LGTM - what were u thinking Danny? Make sure to update the docs. |
I still don't like pulling one state class into another. but I also don't see a way around it if we want to do something like this |
@markwhitfeld - Can u PR docs for this? |
Hi! When would I choose this over the earlier introduced dynmic selector pattern ( Main benefit I see is the use in |
@juliusstoerrle See the docs added in PR #511 |
Implements solution proposed in #426 to expose the createSelector function.
Provides a solution for #413.
It allows for this sort of syntax, enabling a static form of parameterized selectors: