Add development mode with freeze #409
Conversation
markwhitfeld
force-pushed
the
add-dev-mode-with-freeze
branch
from
f19bc1b to
99acec0
Compare
packages/store/src/module.ts
Outdated
| type ModuleOptions = Partial<NgxsConfig>; | ||
|
|
||
| export function ngxsConfigFactory(options: ModuleOptions): NgxsConfig { | ||
| const config = Object.assign(new NgxsConfig(), options); |
There was a problem hiding this comment.
Why not just return directly rather than assign a variable and return that in the next line?
package.json
Outdated
| @@ -116,6 +116,8 @@ | |||
| "zone.js": "^0.8.26" | |||
| }, | |||
| "dependencies": { | |||
| "@types/deep-freeze-strict": "^1.1.0", | |||
There was a problem hiding this comment.
Types should be a dev dependency.
| @@ -3,14 +3,21 @@ import { Injectable } from '@angular/core'; | |||
| import { StateOperations } from './internals'; | |||
| import { InternalDispatcher } from './dispatcher'; | |||
| import { StateStream } from './state-stream'; | |||
| import { NgxsConfig } from '@ngxs/store/src/symbols'; | |||
|
|
|||
| const deepFreeze = require('deep-freeze-strict'); | |||
There was a problem hiding this comment.
Why use require here? import * as deepFreeze from 'deep-freeze-strict';.
markwhitfeld
force-pushed
the
add-dev-mode-with-freeze
branch
from
99acec0 to
6d41b79
Compare
| @@ -3,14 +3,21 @@ import { Injectable } from '@angular/core'; | |||
| import { StateOperations } from './internals'; | |||
| import { InternalDispatcher } from './dispatcher'; | |||
| import { StateStream } from './state-stream'; | |||
| import { NgxsConfig } from './symbols'; | |||
|
|
|||
| const deepFreeze = require('deep-freeze-strict'); | |||
There was a problem hiding this comment.
Why use require here? I'd do: import * as deepFreeze from 'deep-freeze-strict';
There was a problem hiding this comment.
That lib doesn't support import. Ngrx also had to import it this way.
There was a problem hiding this comment.
OK. Generally speaking when it doesn't support that you can use the wildcard import. :) - https://www.typescriptlang.org/docs/handbook/modules.html
There was a problem hiding this comment.
No luck. It says:
[ts] Module '"c:/Code/OpenSource/ngxs/node_modules/@types/deep-freeze-strict/index"' resolves to a non-module entity and cannot be imported using this construct.
| private _stateStream: StateStream, | ||
| private _dispatcher: InternalDispatcher, | ||
| private _config: NgxsConfig | ||
| ) {} | ||
|
|
||
| public getRootStateOperations(): StateOperations<any> { |
There was a problem hiding this comment.
Lets remove public from this method, its redudant.
|
Also, can you add a note to the docs and change log for this? |
|
@amcdnl I have addressed the issues you raised. |
|
Merged! :) |
No description provided.