Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): run actions outside zones for perf #383

Merged
merged 1 commit into from
May 16, 2018
Merged

fix(perf): run actions outside zones for perf #383

merged 1 commit into from
May 16, 2018

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented May 16, 2018

Runs actions outside of zones for performance reasons.

@amcdnl amcdnl added this to the 3.1.0 milestone May 16, 2018
@amcdnl amcdnl self-assigned this May 16, 2018
@amcdnl amcdnl requested review from markwhitfeld and deebloo May 16, 2018 16:01
@deebloo
Copy link
Member

deebloo commented May 16, 2018

i mean it seems fine to me. do we have anything to show what the performance improvement would actually be?

@markwhitfeld
Copy link
Member

Yes, I think it would be great if we could have some sort of comparison on performance improvement to go with this... Possibly in the docs as a motivation why.

Do you know what the potential impact of running angular services outside the angular zone would be? Http calls, etc.

@markwhitfeld
Copy link
Member

Oh and we may need to make sure that if anyone subscribed to the action stream that it would run back on the angular zone because they may subscribe to that in a component. Not sure how angular would behave if you update component state or async piped observables outside the angular zone.

@amcdnl
Copy link
Member Author

amcdnl commented May 16, 2018

I'm going to go ahead and merge this and we can make the subscribe run in zone in a separate PR if we find its needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants