Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): fix enum compile out #345

Merged
merged 4 commits into from
May 1, 2018
Merged

fix(store): fix enum compile out #345

merged 4 commits into from
May 1, 2018

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented May 1, 2018 •
edited
Loading

  • Fixes enums getting compiled out at prod build time
  • Fixes race case when loading router module in production
  • Properly imports the router module using @dynamic
  • Minor code cleanup

@amcdnl amcdnl self-assigned this May 1, 2018
@amcdnl amcdnl requested a review from deebloo May 1, 2018 19:35
@amcdnl amcdnl requested a review from leon May 1, 2018 21:00
@amcdnl amcdnl merged commit 766493a into master May 1, 2018
@amcdnl amcdnl deleted the enum-fix branch May 1, 2018 21:03
@leon
Copy link
Contributor

leon commented May 1, 2018

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deebloo deebloo Awaiting requested review from deebloo

@leon leon Awaiting requested review from leon

Assignees

@amcdnl amcdnl

Labels
domain: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcdnl @leon