-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(store): use ngServerMode
to check whether we are in SSR
#2287
Conversation
View your CI Pipeline Execution ↗ for commit ffe70a1.
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/router-plugin
@ngxs/hmr-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change -92B -0.07% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files added (1)
Files removed (3)
Total files change -139.26KB -67.72% Final result: ✅ View report in BundleMon website ➡️ |
Code Climate has analyzed commit c3f5df9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
In this commit, we replace `isPlatformServer` in the store with the new built-in variable `ngServerMode`, available starting from Angular 19. This compile-time variable allows the code to be tree-shakable.
c3f5df9
to
ffe70a1
Compare
In this commit, we replace
isPlatformServer
in the store with the new built-in variablengServerMode
, available starting from Angular 19.This compile-time variable allows the code to be tree-shakable.