-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storage-plugin): mark engine tokens as pure #2249
Conversation
`new` expressions are considered side-effectful. The `/* @__PURE__ */` hint tells the bundler that `new InjectionToken` has no side effects and that the output of this expression can be safely removed if unused. Therefore, if `LOCAL_STORAGE_ENGINE` is never used, it can be dropped.
a96e948
to
19a5db7
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 19a5db7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
commit: |
Code Climate has analyzed commit 19a5db7 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (1)
Unchanged files (8)
Total files change +15B +0.07% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (3)
Total files change -117B -0.05% Final result: ✅ View report in BundleMon website ➡️ |
new
expressions are considered side-effectful. The/* @__PURE__ */
hint tells the bundler thatnew InjectionToken
has no side effects and that the output of this expression can be safely removed if unused. Therefore, ifLOCAL_STORAGE_ENGINE
is never used, it can be dropped.