perf(store): avoid going over states list every time action is dispatched

[arturovt]

In this commit, I'm working on optimizing how we handle action dispatches by avoiding repeated traversal of the states list. Instead, we prepare a map each time a new state is added, allowing us to perform O(1) lookups by action type in the future. This approach reduces complexity and improves performance.

I've tested it with benchmark.js, and here are the results:

class Increment {
  static readonly type = 'Increment';
}

const states = Array.from({ length: 50 }).map((_, index) => {
  @State({
    name: `counter_${index + 1}`,
    defaults: 0,
  })
  @Injectable()
  class CounterState {
    @Action(Increment)
    increment(ctx: StateContext<number>) {
      ctx.setState((counter) => counter + 1);
    }
  }

  return CounterState;
});

store.dispatch() before changes x 3,435 ops/sec ±0.45% (65 runs sampled)
store.dispatch() after changes x 3,942 ops/sec ±1.21% (25 runs sampled)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2bf876b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx run-many --target=test --all --configuration=ci --base=remotes/origin/master --head=HEAD
• nx run-many --target=lint --all --configuration=ci --base=remotes/origin/master --head=HEAD
• nx lint-types store
• nx run-many --target=build --all

---

Sent with 💌 from NxCloud.

[pkg-pr-new]

Open in Stackblitz

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/[email protected]

commit: 2bf876b

[bundlemon]

BundleMon

Unchanged files (6)

Status	Path	Size	Limits
✅	fesm2022/ngxs-store.mjs	100.2KB	101KB / +0.5%
✅	fesm2022/ngxs-store-internals.mjs	11.36KB	13KB / +0.5%
✅	fesm2022/ngxs-store-internals-testing.mjs	6.83KB	7KB / +0.5%
✅	fesm2022/ngxs-store-operators.mjs	6.22KB	7KB / +0.5%
✅	fesm2022/ngxs-store-plugins.mjs	2.04KB	3KB / +0.5%
✅	fesm2022/ngxs-store-experimental.mjs	1.4KB	2KB / +0.5%

No change in files bundle size

Unchanged groups (2)

Status	Path	Size	Limits
✅	@ngxs/store(esm2022)[gzip] ./esm2022/**/*.mjs	220.38KB	+1%
✅	@ngxs/store(fesm2022)[gzip] ./fesm2022/*.mjs	30.66KB	+1%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (NGXS Plugins)

Unchanged files (9)

Status	Path	Size	Limits
✅	Plugins(fesm2022)[gzip] storage-plugin/fesm2022/ngxs-storage-plugin.m js	4.15KB	+0.5%
✅	Plugins(fesm2022)[gzip] router-plugin/fesm2022/ngxs-router-plugin.mjs	3.2KB	+0.5%
✅	Plugins(fesm2022)[gzip] websocket-plugin/fesm2022/ngxs-websocket-plug in.mjs	2.64KB	+0.5%
✅	Plugins(fesm2022)[gzip] hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs	2.61KB	+0.5%
✅	Plugins(fesm2022)[gzip] form-plugin/fesm2022/ngxs-form-plugin.mjs	2.59KB	+0.5%
✅	Plugins(fesm2022)[gzip] devtools-plugin/fesm2022/ngxs-devtools-plugin .mjs	2.23KB	+0.5%
✅	Plugins(fesm2022)[gzip] logger-plugin/fesm2022/ngxs-logger-plugin.mjs	2.09KB	+0.5%
✅	Plugins(fesm2022)[gzip] storage-plugin/fesm2022/ngxs-storage-plugin-i nternals.mjs	875B	+0.5%
✅	Plugins(fesm2022)[gzip] router-plugin/fesm2022/ngxs-router-plugin-int ernals.mjs	411B	+0.5%

No change in files bundle size

Unchanged groups (1)

Status	Path	Size	Limits
✅	All Plugins(fesm2022)[gzip] ./-plugin/fesm2022/.mjs	20.76KB	+0.5%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (Integration Projects)

Unchanged files (3)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng18/dist-integration/browser/mai n-(hash).js	71.74KB	+1%
✅	Main bundles(Gzip) hello-world-ng17/dist-integration/main.(hash) .js	68.65KB	+1%
✅	Main bundles(Gzip) hello-world-ng16/dist-integration/main.(hash) .js	67.68KB	+1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[codeclimate]

Code Climate has analyzed commit 8a7cca6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

[markwhitfeld]

Great improvement! I would love to know the performance change when you have 100 states and 10 actions each, and fire each of the 1000 actions.

PS. I would like to chat with you about the direction I want to go with the action handler registration, because I think that it will bring much improvement to the code.

[markwhitfeld]

You just need to update the max bundle size for the main bundle. Currently it is 100kb, but you can change it to 101kb to make this pass