Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust details on injectContainerState #2195

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

markwhitfeld
Copy link
Member

This PR improves details around injectContainerState and removes references to v4 in the docs.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

@markwhitfeld markwhitfeld changed the base branch from master to release July 24, 2024 14:56
Copy link

nx-cloud bot commented Jul 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b406df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Jul 24, 2024

BundleMon (Integration Projects)

Files updated (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
67.54KB (-1.06KB -1.55%) +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.53KB (-1.11KB -1.6%) +1%

Total files change -2.18KB -1.57%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt merged commit 36b03ae into release Jul 24, 2024
12 of 13 checks passed
@arturovt arturovt deleted the docs/update-v4-mentions branch July 24, 2024 15:12
Copy link

codeclimate bot commented Jul 24, 2024

Code Climate has analyzed commit 2b406df and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.5% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld added this to the v18.1.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants