fix(store): decouple state signal updates from synchronous changes #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we decouple state signal updates from synchronous changes to adhere to constraints on updates inside effects. Situations may arise where actions are dispatched within effects, and if these actions are synchronous, the state signal would also receive synchronous updates. This can lead to an error indicating that signal writes are not permitted within effects.
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 75bb611. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (2)
Total files change +1.85KB +1.36% Final result: ❌ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit 75bb611 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
markwhitfeld
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we decouple state signal updates from synchronous changes to adhere to constraints on updates inside effects. Situations may arise where actions are dispatched within effects, and if these actions are synchronous, the state signal would also receive synchronous updates. This can lead to an error indicating that signal writes are not permitted within effects.
Resolves #2180