fix(store): update ActionDef new to return any

[arturovt]

No description provided.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 73df8f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx run-many --target=test --all --configuration=ci --maxWorkers=4
• nx run-many --target=lint --all
• nx lint-types store
• nx run-many --target=build --all

---

Sent with 💌 from NxCloud.

[bundlemon]

BundleMon (Integration Projects)

Unchanged files (2)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng17/dist-integration/main.(hash) .js	68.48KB	+1%
✅	Main bundles(Gzip) hello-world-ng16/dist-integration/main.(hash) .js	67.03KB	+1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[markwhitfeld]

Looks like this is still a work in progress (given the to do).
What is this PR for?

[arturovt]

I removed TReturn from ActionDef, where it was new (...args: TArgs): TReturn, since it was redundant. By mistake, I changed it to ThisType, thinking it would infer the instance type. I now believe I just need to use any as the return type for new.

[markwhitfeld]

What is the problem that you are looking to solve by removing the TReturn?
Or was is the motivation for removing it?

[arturovt]

We have code where ofActionDispatched accepts a function parameter declared as shown in the test. Attempting to access result.errorType throws an error. Previously, result was inferred as any in this specific case. The use of TReturn wasn't resolving any issues, so I intend for new() to always return any.

[markwhitfeld]

@arturovt this has regressed from previous type matching capabilities on the action type.
I will add a commit to fix this and demonstrate the capabilities I am referring to.

[markwhitfeld]

@arturovt I have readded the correct typing and added tests that demonstrate the usages.
Hopefully this compiles, I did this in the github editor so I didn't have the build tooling.