fix(store): change instanceof Promise to isPromise to allow any promisable object
#2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romisable object We need to use `isPromise` instead of checking whether `result instanceof Promise`. In zone.js patched environments, `global.Promise` is the `ZoneAwarePromise`. Some APIs, which are likely not patched by zone.js for certain reasons, might not work with `instanceof`. For instance, the dynamic import returns a native promise (not a `ZoneAwarePromise`), causing this check to be falsy.
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1d21f86. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (1)
Total files change +34B +0.05% Final result: ✅ View report in BundleMon website ➡️ |
|
Ugh the Circle always randomly failing with a timeout... |
markwhitfeld
approved these changes
Feb 5, 2024
markwhitfeld
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
isPromiseinstead of checking whetherresult instanceof Promise.In zone.js patched environments,
global.Promiseis theZoneAwarePromise. Some APIs,which are likely not patched by zone.js for certain reasons, might not work with
instanceof.For instance, the dynamic import returns a native promise (not a
ZoneAwarePromise), causingthis check to be falsy.