fix(store): ensure features are initialized after root state #2083
Conversation
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3b57ef5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
arturovt
force-pushed
the
fix/features-last
branch
from
31acbfd to
a7deaff
Compare
BundleMon (Integration Projects)Files updated (1)
Total files change +34B +0.05% Final result: ✅ View report in BundleMon website ➡️ |
We have a check that ensures states are initialized in the correct order and that the `UpdateState` action shouldn't be dispatched before the `InitState` action. This code updates the order of environment providers to place features at the end. As a result, the root environment initializer runs earlier, dispatching the `InitState` action.
arturovt
force-pushed
the
fix/features-last
branch
from
a7deaff to
3b57ef5
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 16ae0d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
markwhitfeld
changed the title
|
@arturovt do you have any idea on why the unit tests might be timing out? |
|
I don't know, it's typical for Circle to time out, but there's no reason. Seems like it's executed more than it's allowed to. |
arturovt
force-pushed
the
fix/features-last
branch
from
f5b7d8c to
16ae0d0
Compare
|
Code Climate has analyzed commit 16ae0d0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
We have a check that ensures states are initialized in the correct order and that the
UpdateStateaction shouldn't be dispatched before theInitStateaction. This code updates the order of environment providers to place features at the end. As a result, the root environment initializer runs earlier, dispatching theInitStateaction.