-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router-plugin): expose NGXS_ROUTER_PLUGIN_OPTIONS
privately
#2037
Conversation
2c5dd94
to
4fe7ff2
Compare
BundleMonUnchanged files (3)
No change in files bundle size Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files added (2)
Files updated (2)
Unchanged files (12)
Total files change +909B +1.56% Groups updated (3)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (2)
Unchanged files (1)
Total files change -51B -0.02% Final result: ✅ View report in BundleMon website ➡️ |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 09bd789. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
bf8cd79
to
ba1f8cd
Compare
ba1f8cd
to
09bd789
Compare
Code Climate has analyzed commit 09bd789 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
This PR exposes some of the internal tokens used inside the Router Plugin in an
internals
sub-package and with the barred-oh variable name to indicate its private nature. This approach is used because this API is not part of an "official" API that has been committed to by the library and could be changed (within reason) at some point in the future, without being marked as a "breaking change", although this would most likely still be limited to a minor version change to the library.These tokens have been exposed in order to resolve the reasonable extensibility needs that were raised in PR #2030.