feat(storage-plugin): enable providing storage engine individually #1935

arturovt · 2022-11-10T19:59:46Z

Issue: #598

bundlemon · 2022-11-10T20:07:53Z

BundleMon

Unchanged files (6)

Status	Path	Size	Limits
✅	fesm5/ngxs-store.js	137.67KB	145KB / +0.5%
✅	fesm2015/ngxs-store.js	118.39KB	125KB / +0.5%
✅	fesm5/ngxs-store-operators.js	10.07KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	9.94KB	15KB / +0.5%
✅	fesm5/ngxs-store-internals.js	6.58KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	5.65KB	20KB / +0.5%

No change in files bundle size

Unchanged groups (6)

Status	Path	Size	Limits
✅	@ngxs/store(esm5)[gzip] _{./esm5/*/.js}	179.31KB	+1%
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	172.59KB	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	40.57KB	+1%
✅	@ngxs/store(fesm5)[gzip] _./fesm5/*.js	29.86KB	+1%
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	27.33KB	+1%
✅	@ngxs/store(umd.min)[gzip] _{./bundles/*.umd.min.js}	13.65KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-11-10T20:07:57Z

BundleMon (NGXS Plugins)

Files updated (4)

Status	Path	Size	Limits
❌	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.98KB (+284B +3.6%)	+1%
❌	Plugins(fesm5)[gzip] _{storage-plugin/fesm5/ngxs-storage-plugin.js}	4.67KB (+274B +6.08%)	+1%
❌	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	4.35KB (+263B +6.27%)	+1%
❌	Plugins(umd.min)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.min.js}	2.54KB (+156B +6.38%)	+1%

Unchanged files (24)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.96KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.87KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	6.53KB	+1%
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	6.5KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	6.44KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	5.77KB	+1%
✅	Plugins(fesm5)[gzip] _{hmr-plugin/fesm5/ngxs-hmr-plugin.js}	3.62KB	+1%
✅	Plugins(fesm5)[gzip] _{websocket-plugin/fesm5/ngxs-websocket-plugin. js}	3.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	3.25KB	+1%
✅	Plugins(fesm5)[gzip] _{devtools-plugin/fesm5/ngxs-devtools-plugin.js}	3.21KB	+1%
✅	Plugins(fesm5)[gzip] _{router-plugin/fesm5/ngxs-router-plugin.js}	3.15KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	3.15KB	+1%
✅	Plugins(umd.min)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js}	3.1KB	+1%
✅	Plugins(fesm5)[gzip] _{form-plugin/fesm5/ngxs-form-plugin.js}	3.07KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	3.03KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	2.89KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.74KB	+1%
✅	Plugins(fesm5)[gzip] _{logger-plugin/fesm5/ngxs-logger-plugin.js}	2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. min.js}	2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.min. js}	2.43KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.37KB	+1%
✅	Plugins(umd.min)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js}	2.18KB	+1%
✅	Plugins(umd.min)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. min.js}	1.95KB	+1%
✅	Plugins(umd.min)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js}	1.86KB	+1%

Total files change +977B +0.88%

Groups updated (6)

Status	Path	Size	Limits
❌	All Plugins(esm5)[gzip] _{./-plugin/esm5/**/.js}	124.79KB (+4.36KB +3.62%)	+1%
❌	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	119.46KB (+4.34KB +3.77%)	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	47.06KB (+284B +0.59%)	+1%
❌	All Plugins(fesm5)[gzip] _{./-plugin/fesm5/.js}	23.74KB (+274B +1.14%)	+1%
❌	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	21.78KB (+263B +1.19%)	+1%
✅	All Plugins(umd.min)[gzip] _{./-plugin/bundles/.umd.min.js}	16.54KB (+156B +0.93%)	+1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-11-10T20:07:59Z

BundleMon (Integration Projects)

Files updated (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng11-ivy/dist-integration/main.(h ash).js}	71.13KB (+127B +0.17%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.78KB (+124B +0.17%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65.46KB (+123B +0.18%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.84KB (+109B +0.16%)	+1%

Total files change +483B +0.17%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

codeclimate · 2022-12-06T21:23:59Z

Code Climate has analyzed commit 197ce9e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.1% change).

View more on Code Climate.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.6/3.8.0) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.6/3.8.0) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.6/3.8.0) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.8.0`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#380-2023-03-29) [Compare Source](ngxs/store@v3.7.6...v3.8.0) - Feature: Build packages in Ivy format [#1945](ngxs/store#1945) - Feature: Add advanced selector utilities [#1824](ngxs/store#1824) - Feature: Expose `ActionContext` and `ActionStatus` [#1766](ngxs/store#1766) - Feature: `ofAction*` methods should have strong types [#1808](ngxs/store#1808) - Feature: Improve contextual type inference for state operators [#1806](ngxs/store#1806) [#1947](ngxs/store#1947) - Feature: Enable warning on unhandled actions [#1870](ngxs/store#1870) [#1951](ngxs/store#1951) - Feature: Router Plugin - Provide more actions and navigation timing option [#1932](ngxs/store#1932) - Feature: Storage Plugin - Allow providing namespace for keys [#1841](ngxs/store#1841) - Feature: Storage Plugin - Enable providing storage engine individually [#1935](ngxs/store#1935) - Feature: Devtools Plugin - Add new options to the `NgxsDevtoolsOptions` interface [#1879](ngxs/store#1879) - Feature: Devtools Plugin - Add trace options to `NgxsDevtoolsOptions` [#1968](ngxs/store#1968) - Feature: Form Plugin - Allow `ngxsFormDebounce` to be string [#1972](ngxs/store#1972) - Performance: Tree-shake patch errors [#1955](ngxs/store#1955) - Fix: Get descriptor explicitly when it's considered as a class property [#1961](ngxs/store#1961) - Fix: Avoid delayed updates from state stream [#1981](ngxs/store#1981) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1837 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

arturovt force-pushed the feat/598-engine-per-key branch 2 times, most recently from b6568df to a4fa0f8 Compare November 10, 2022 20:40

arturovt added the type: feature label Nov 13, 2022

arturovt added this to the v3.8.0 milestone Nov 23, 2022

arturovt force-pushed the feat/598-engine-per-key branch 3 times, most recently from 42bbf81 to a7e4227 Compare December 6, 2022 19:55

markwhitfeld approved these changes Dec 6, 2022

View reviewed changes

markwhitfeld marked this pull request as ready for review December 6, 2022 20:40

markwhitfeld requested review from kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners December 6, 2022 20:40

feat(storage-plugin): enable providing storage engine individually

0caad9f

arturovt force-pushed the feat/598-engine-per-key branch from a7e4227 to 0caad9f Compare December 6, 2022 21:19

chore: update CHANGELOG.md

197ce9e

arturovt merged commit 7ca104f into master Dec 6, 2022

arturovt deleted the feat/598-engine-per-key branch December 6, 2022 21:33

markwhitfeld added the released label Mar 29, 2023

abdulrahman305 mentioned this pull request Jul 3, 2024

[Snyk] Upgrade: , , , , abdulrahman305/auptimizer#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(storage-plugin): enable providing storage engine individually #1935

feat(storage-plugin): enable providing storage engine individually #1935

arturovt commented Nov 10, 2022

bundlemon bot commented Nov 10, 2022 •

edited

Loading

bundlemon bot commented Nov 10, 2022 •

edited

Loading

bundlemon bot commented Nov 10, 2022 •

edited

Loading

codeclimate bot commented Dec 6, 2022

feat(storage-plugin): enable providing storage engine individually #1935

feat(storage-plugin): enable providing storage engine individually #1935

Conversation

arturovt commented Nov 10, 2022

bundlemon bot commented Nov 10, 2022 • edited Loading

BundleMon

bundlemon bot commented Nov 10, 2022 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Nov 10, 2022 • edited Loading

BundleMon (Integration Projects)

codeclimate bot commented Dec 6, 2022

bundlemon bot commented Nov 10, 2022 •

edited

Loading

bundlemon bot commented Nov 10, 2022 •

edited

Loading

bundlemon bot commented Nov 10, 2022 •

edited

Loading