feat: add support for angular 13

[internalsystemerror]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Angular 12 max supported version

What is the new behavior?

Angular 13 max supported version

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Closes #1797

[internalsystemerror]

This is marked as a draft PR (maintainers are ofc welcome to take control over this) and so far allows the Angular 13 installation, and has an added ng13 integration test.

[internalsystemerror]

This is currently blocked by angular-eslint/angular-eslint#715, using the next version of this package succeeds (at least locally), so a simple upgrade once this is released should suffice.

[splincode]

Good job!

[internalsystemerror]

I realised over this weekend that I'd run the integration test against the wrong project so I decided to take another look. In order to run ng update against a copy of the v12 integration, I had copied this into a different project, ran the upgrade and then copied it back. Upgrading @angular-eslint/angular-eslint fixed the issue for my other project, however @angular-eslint/angular-eslint is not used in this project.

So upon taking another look, it is @angular-builders/jest (v11) that is throwing the error here and upgrading to v13 of this package fixes it. However, I'm still struggling to get set up running these integrations correctly so I will fix any subsequent issues that are flagged in CI. (Edit: Now resolved)

[splincode]

Great job 👏

[irowbin]

Tests depending on ngxs are failing after Angular v13 upgrade. I think this is the PR that resolves those.?

[splincode]

@irowbin could you please provide a minimum repo so that we can check if this is so

[razmjo-netlinks]

Guys, I am waiting for this pull request. I need to upgrade to angular 13.

[irowbin]

@irowbin could you please provide a minimum repo so that we can check if this is so

@splincode The same tests works on v12 but the same test doesn't work on v13 as it prints:

Error: Unexpected value 'NgxsRootModule' imported by the module 'DynamicTestModule'.
Please add an @NgModule annotation.

Not sure if this is due to .mjs extension by v13 packager or something like that. We use jest so haven't check on jasmine/karma

[jonaskuske]

@irowbin Try to re-run npx ngcc, that helped when I saw that error

[splincode]

@jonaskuske @irowbin @internalsystemerror try install @ngxs/store@dev

[internalsystemerror]

@irowbin Try to re-run npx ngcc, that helped when I saw that error

This is something that I also had to do multiple times during the update from v12 to v13 in this PR. The first round of ngcc fails due to the package format change... The second round seems to ignore anything previously and reruns everything.

@jonaskuske @irowbin @internalsystemerror try install @ngxs/store@dev

Our projects using @ngxs/store and the related plugins are all still stuck on v12 of angular even with this as we have other dependencies such as @ng-bootstrap/ng-bootstrap which still require v13 support.

[markwhitfeld]

Hi @internalsystemerror and everybody else.
Apologies for being off the radar on this. I have been head down collaborating with the Angular team, adding NG13 support to StackBlitz has been no small task. The Ivy partial package format is easy, it's the mjs files and exports in package.json that is making it a real challenge. Anyway, that's another story.

My aim is to get this NGXS release out in the next few days.

[suer85]

Just curious if there is any status update on this?

[splincode]

@markwhitfeld @arturovt any news?

@suer85 hello) we are blocked by #1804

[bendehghan]

Hey guys, will there be a build that supports angular 13? The last release is well before the angular update. Pretty soon we'll be at angular 14...

Thanks!

[splincode]

@bendehghan hello, use 3.7.3

[bendehghan]

I see. Thanks.
3.7.3 is only a tag. I kept looking in the releases and didn't think of tags.

I get this on 3.7.3. Is that an issue on my side or yours?

Processing legacy "View Engine" libraries:
- @ngxs/devtools-plugin [es2015/esm2015] (git+https://github.com/ngxs/store.git)
- @ngxs/storage-plugin [es2015/esm2015] (git+https://github.com/ngxs/store.git)
- @ngxs/store/internals/testing [es2015/esm2015] (git+https://github.com/ngxs/store.git)
- @ngxs/store/operators [es2015/esm2015] (git+https://github.com/ngxs/store.git)
- @ngxs/store/internals [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/devtools-plugin [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/store [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/logger-plugin [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/router-plugin [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/storage-plugin [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/store/internals/testing [main/umd] (git+https://github.com/ngxs/store.git)
- @ngxs/store/operators [main/umd] (git+https://github.com/ngxs/store.git)
Encourage the library authors to publish an Ivy distribution.

[internalsystemerror]

@bendehghan I believe that's planned for v4, it was mentioned in here: #827