Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router-plugin): build compatibility for NGXS Router plugin with Ivy #1459

Merged
merged 3 commits into from
Nov 25, 2019
Merged

fix(router-plugin): build compatibility for NGXS Router plugin with Ivy #1459

merged 3 commits into from
Nov 25, 2019

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1223, #1165

What is the new behavior?

image

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@splincode splincode changed the title fix(store): build compatibility for NGXS Router plugin with Ivy fix(router-plugin): build compatibility for NGXS Router plugin with Ivy Nov 24, 2019
markwhitfeld
markwhitfeld reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad we are getting to the bottom of this!
See comments...

docs/plugins/router.md Outdated Show resolved Hide resolved
packages/router-plugin/src/router.module.ts Show resolved Hide resolved
arturovt
arturovt approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@arturovt arturovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just fix Mark's tweaks.

@splincode splincode merged commit 579fb02 into master Nov 25, 2019
@splincode splincode deleted the fix/ngxs-router-ivy branch November 25, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld left review comments

@arturovt arturovt arturovt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @markwhitfeld @arturovt