Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run SSR tests with cypress #1281

Merged
merged 7 commits into from
Oct 2, 2019
Merged

build: run SSR tests with cypress #1281

merged 7 commits into from
Oct 2, 2019

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Aug 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@markwhitfeld @splincode

What does this PR introduce?

  • SSR tests are running with cypress as they have to be.
  • Removed unnecessary packages, less packages = faster installation on the CI
  • Removed @nguniversal/express-engine as it's just not needed.
  • server.ts code became cleaner and much less than with @nguniversal/express-engine.
  • Since now SSR tests can be run in the interactive GUI and such way is much easier to debug and watch what's wrong etc.
  • That code ORIGIN_URL was just copied from some example and it is not used.

@splincode
Copy link
Member

@arturovt, please fix conflicts

# Conflicts:
#	package.json
#	yarn.lock
@markwhitfeld markwhitfeld merged commit 5898acd into master Oct 2, 2019
@markwhitfeld markwhitfeld deleted the build/cypress-ssr branch October 2, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants