Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools-plugin): send action even if error was thrown #1249

Merged
merged 3 commits into from
Aug 22, 2019

Conversation

arturovt
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #329

prev-devtools

What is the new behavior?

after-devtools

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@splincode @markwhitfeld

This is very small bugfix for the old #329 issue. In the current behavior our devtools-plugin notifies Chrome extension only if everything is OK and no error is thrown. This PR fixes this behavior and notifies Chrome extension to log the state even if error was thrown. Given the following code:

catchError(error => {
  ctx.patchState({ counter });
  throw error;
})

This change will not be shown in the Chrome extension in the current behavior.

@markwhitfeld
Copy link
Member

@arturovt @splincode Please review my changes. Just made the logic for sending to the dev tool shared.

@markwhitfeld markwhitfeld requested a review from splincode August 22, 2019 18:12
@arturovt
Copy link
Member Author

@markwhitfeld I'm OK with your changes :)

@arturovt arturovt merged commit c7f6788 into master Aug 22, 2019
@arturovt arturovt deleted the fix/devtools-error branch August 22, 2019 18:17
@markwhitfeld markwhitfeld added this to the 3.5.x milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants