-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hmr-plugin): remove @angularclass/hmr peer dependency #1205
Conversation
@markwhitfeld @arturovt ping |
# Conflicts: # package.json
# Conflicts: # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We gave feedback on the PR, and then when I look at the changes there is a whole lot of new stuff in the PR unrelated to the feedback and not entirely necessary for the PR.
This has happened quite often and is a bit frustrating. Please don't do this. It makes the review process tedious because we have to start again as reviewers.
# Conflicts: # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reverting those unrelated changes.
Some changes requested below...
@markwhitfeld @arturovt done |
Do you have to remove this package from the root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... although I'm not sure why there are all those other unrelated package upgrades in those last commits?
@markwhitfeld rebases after Renovate's updates |
@arturovt I was referring to the changes in @splincode's 'fix' commits. Was this just yarn being eager? |
I guess it were merge conflicts :) |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We depend on a package that has not been updated for 2 years, while using only 2 functions from there.
What is the new behavior?
Now we use our own functionality and it works
Does this PR introduce a breaking change?
Other information