Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): ensure @Action() is not used with static methods #1203

Merged
merged 3 commits into from
Aug 6, 2019
Merged

fix(store): ensure @Action() is not used with static methods #1203

merged 3 commits into from
Aug 6, 2019

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Aug 2, 2019

PR Checklist

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@arturovt
Copy link
Member Author

arturovt commented Aug 6, 2019

@markwhitfeld ping

@markwhitfeld markwhitfeld changed the title test(store): ensure @Action() is not used with static methods fix(store): ensure @Action() is not used with static methods Aug 6, 2019
markwhitfeld
markwhitfeld approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@markwhitfeld markwhitfeld merged commit d06c644 into master Aug 6, 2019
@markwhitfeld markwhitfeld deleted the test/static-action branch August 6, 2019 11:53
@markwhitfeld markwhitfeld added this to the 3.5.x milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@markwhitfeld markwhitfeld markwhitfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@arturovt @markwhitfeld @splincode