Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(socket-plugin): don't stop WebSocketSubject stream after dispatching WebSocketDisconnected #1091

Merged
merged 3 commits into from
May 25, 2019
Merged

fix(socket-plugin): don't stop WebSocketSubject stream after dispatching WebSocketDisconnected #1091

merged 3 commits into from
May 25, 2019

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #977

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@arturovt arturovt requested review from markwhitfeld and splincode and removed request for markwhitfeld and splincode May 24, 2019 22:37
@arturovt arturovt changed the title fix(socket-plugin): don`t stop WebSocketSubject stream fix(socket-plugin): don't stop WebSocketSubject stream after dispatching WebSocketDisconnected May 24, 2019
markwhitfeld
markwhitfeld approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!
Well done on fixing and adding to the tests too.

markwhitfeld
markwhitfeld approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thanks for fixing the public_api.ts exports.

@markwhitfeld markwhitfeld merged commit dad8ead into ngxs:master May 25, 2019
@arturovt arturovt deleted the fix/issue-977 branch May 26, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@markwhitfeld markwhitfeld markwhitfeld approved these changes

Assignees
No one assigned
Labels
domain: plugins ready to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturovt @markwhitfeld @splincode