Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jest-builders #1068

Merged
merged 5 commits into from
May 20, 2019
Merged

feat: add jest-builders #1068

merged 5 commits into from
May 20, 2019

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Use Jest instead Karma

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@splincode splincode requested review from markwhitfeld and arturovt and removed request for markwhitfeld May 18, 2019 17:08
Copy link
Member

@arturovt arturovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just add cacheDirectory as we discussed 🎉

@splincode
Copy link
Member Author

@arturovt done

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Strange though that it thinks that you changed the whole .gitignore file.
PS. Can't wait to use this!!!

@markwhitfeld
Copy link
Member

@splincode are there any docs updates needed?

@markwhitfeld markwhitfeld merged commit 6241ebb into master May 20, 2019
@markwhitfeld markwhitfeld deleted the feature/jest branch May 20, 2019 11:29
@splincode
Copy link
Member Author

@markwhitfeld not need it

@markwhitfeld markwhitfeld mentioned this pull request May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants