Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): expose NgxsModuleOptions as a named type #1031

Merged
merged 2 commits into from
May 4, 2019
Merged

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Now it is not clear how to specify the data type.

What is the new behavior?

The ability to specify in your code what type of data the settings have

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have generally been opposed to making objects that are only passed as parameters on the public API into their own thing but I think that this case makes sense.

@markwhitfeld
Copy link
Member

markwhitfeld commented May 4, 2019

This should be a feature because it is adding public api.
Even that it is just giving a name to a type.

@markwhitfeld markwhitfeld changed the title fix(store): expose NgxsModuleOptions feat(store): expose NgxsModuleOptions May 4, 2019
@markwhitfeld markwhitfeld changed the title feat(store): expose NgxsModuleOptions feat(store): expose NgxsModuleOptions as a named type May 4, 2019
@splincode splincode merged commit d54fdbc into master May 4, 2019
@splincode splincode deleted the feat/options branch May 11, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants