fix: remove DispatchAction and unnecessary closures

[arturovt]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[pdemilly]

How do you now return an action which returns nothing. In some places in my code I have this. I guess I could replace with a dummy action

@Dispatch()
sometimesDo (aValue: boolean) => aValue ? new DoAnActionForVallue(aValue) : new DispatchAction(null)

[arturovt]

How do you now return an action which returns nothing. In some places in my code I have this. I guess I could replace with a dummy action

@Dispatch()
sometimesDo (aValue: boolean) => aValue ? new DoAnActionForVallue(aValue) : new DispatchAction(null)

I wasn't sure that DispatchAction is used by someone, as it wasn't documented. This had to be a private API and I cannot remember why it was exposed as it was 1 year ago. If 2.1.0 is a breaking change for you then just downgrade to the 2.0.0.

DispatchAction is basically useless in the core of this plugin and I wouldn't recommend you using it either.

If the DispatchAction is used in many places you could just do the following:

declare interface Window {
  DummyAction: typeof DummyAction;
}

class DummyAction {
  static readonly type = null;
}

window.DummyAction = DummyAction;

Then click search + replace in your IDE and replace new DispatchAction(null) with new window.DummyAction().