Allow deepMerging of objects #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't want to depend on a library, so I copied the content of the deepMerge package inside the util file. Thanks for the PR, it will be available in the next version. |
|
thanks @ocombe after my PR I thought you'd tell me that XD but what you did is the best approach |
hanyu-natsu
added a commit
to hanyu-natsu/core
that referenced
this pull request
Jan 9, 2018
shouldMerge option of the `setTranslation` method didn't handle non-valid JSON translations object such compiled translations with custom compiler. It is now doing deep merging with lodash. Fixes ngx-translate#532 Change-Id: Ie9d83ef65d42ec9bea93489b11f0abd4ab641c4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.