fix(directive): prevent infinite update for missing translation

[Grolleau]

No description provided.

[Grolleau]

Fixes #1281

[zubSero]

This should work. I tested it locally and it stopped the endless loop.

[hthetiot]

This solve major performance issues we have, since we use Gettext approach and our english key are the same has our translation, the missing translation was triggered causing this infinit render.

[korjikk]

Hi! Is there any specific reason this hasn't been merged yet?

[hthetiot]

We used patch-package to fix this issue on our side, until this PR get merge.

1. npm i patch-package --dev
2. Add "postinstall": "patch-package" to "scripts" in package.json
3. Create "patches/@ngx-translate+core+14.0.0.patch" file with following content:

diff --git a/node_modules/@ngx-translate/core/esm2020/lib/translate.directive.mjs b/node_modules/@ngx-translate/core/esm2020/lib/translate.directive.mjs
index 869a40f..56a12e1 100644
--- a/node_modules/@ngx-translate/core/esm2020/lib/translate.directive.mjs
+++ b/node_modules/@ngx-translate/core/esm2020/lib/translate.directive.mjs
@@ -99,9 +99,9 @@ export class TranslateDirective {
             }
             this.lastParams = this.currentParams;
             let onTranslation = (res) => {
-                if (res !== key) {
+                //if (res !== key) {
                     node.lastKey = key;
-                }
+                //}
                 if (!node.originalContent) {
                     node.originalContent = this.getContent(node);
                 }
diff --git a/node_modules/@ngx-translate/core/fesm2015/ngx-translate-core.mjs b/node_modules/@ngx-translate/core/fesm2015/ngx-translate-core.mjs
index eda8ca6..fdc69da 100644
--- a/node_modules/@ngx-translate/core/fesm2015/ngx-translate-core.mjs
+++ b/node_modules/@ngx-translate/core/fesm2015/ngx-translate-core.mjs
@@ -780,9 +780,9 @@ class TranslateDirective {
             }
             this.lastParams = this.currentParams;
             let onTranslation = (res) => {
-                if (res !== key) {
+                //if (res !== key) {
                     node.lastKey = key;
-                }
+                //}
                 if (!node.originalContent) {
                     node.originalContent = this.getContent(node);
                 }
diff --git a/node_modules/@ngx-translate/core/fesm2020/ngx-translate-core.mjs b/node_modules/@ngx-translate/core/fesm2020/ngx-translate-core.mjs
index b8e86ec..a85f71c 100644
--- a/node_modules/@ngx-translate/core/fesm2020/ngx-translate-core.mjs
+++ b/node_modules/@ngx-translate/core/fesm2020/ngx-translate-core.mjs
@@ -778,9 +778,9 @@ class TranslateDirective {
             }
             this.lastParams = this.currentParams;
             let onTranslation = (res) => {
-                if (res !== key) {
+                //if (res !== key) {
                     node.lastKey = key;
-                }
+                //}
                 if (!node.originalContent) {
                     node.originalContent = this.getContent(node);
                 }

Enjoy English to English and missing translation without redraw.