Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set translations() doesn't use the right private property #524

Closed
82antu opened this issue Apr 27, 2017 · 2 comments · Fixed by #773
Closed

set translations() doesn't use the right private property #524

82antu opened this issue Apr 27, 2017 · 2 comments · Fixed by #773

Comments

@82antu
Copy link

82antu commented Apr 27, 2017

I'm submitting a ... (check one with "x")

[x] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

Current behavior
translateService.translations = myTranslations will save myTranslations on private property _currentLang instead of _translations

Expected/desired behavior
translateService.translations = myTranslations write on _translations property and not _currentLang

Reproduction of the problem
On line
https://github.com/ngx-translate/core/blob/master/src/translate.service.ts#L142
you can easily see the Issue

Please tell us about your environment:

  • ngx-translate version: 6.0.1

  • Angular version: 2.4.10

  • Browser: [all]

@Massimiliano-Perelli
Copy link

It seems to be some typing error, with blocking consequences.

@82antu
Copy link
Author

82antu commented Sep 19, 2017

any news ???

seems that the problem is still there...

    set translations(translations: any) {
        if(this.isolate) {
            this._currentLang = translations;
        } else {
            this.store.translations = translations;
        }
    }

set translations() method still write on _currentLang property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants