-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation of @ngx-translate/core also installs “semantic-release” (since version 12.1.0) #1171
Comments
Thanks, good catch! It'll be fixed in the next version (I won't release a new version just for that) |
Shouldn't it be a dependency on the root package.json? |
Or install without adding to package.json at all? btw: latest semantic-release is v17.0.3 and you are using v8.2.3 |
As long as it works, I'm reluctant to change the setup since it does
releases automatically and it works fine 😁
|
@ocombe Is it released? I still have it installed with @ngx-translate/core 12.1.1 : |
Same issue here. The latest version still installs https://www.npmjs.com/package/@ngx-translate/core/v/12.1.1?activeTab=dependencies |
Can you try 12.1.2 please? Hopefully it should be fixed for good now (based on https://www.npmjs.com/package/@ngx-translate/core/v/12.1.2?activeTab=dependencies) |
Seems fixed, thanks! |
Yep, it's fixed. Thank you @ocombe 🙏 |
Current behavior
The
@ngx-translate/core
package seems to depend onsemantic-release
since v12.1.0:Expected behavior
No installation of
semantic-release
since it’s adevDependency
.Minimal reproduction of the problem with instructions
The text was updated successfully, but these errors were encountered: