Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(store): deprecate createFeatureSelector with root state #3190

Merged
merged 1 commit into from
Oct 20, 2021
Merged

docs(store): deprecate createFeatureSelector with root state #3190

merged 1 commit into from
Oct 20, 2021

Conversation

santoshyadavdev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3179

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@santoshyadavdev
Copy link
Contributor Author

Hi @timdeschryver should I add the migrations as well I can see you have a eslint rule timdeschryver/eslint-plugin-ngrx#155 I can reuse the code from here

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 19, 2021

Preview docs changes for a83195e at https://previews.ngrx.io/pr3190-a83195e8/

@timdeschryver
Copy link
Member

@santoshyadavdev , you can add the migration if you want (as a separate commit, or in another PR).
I don't think you can reuse the code, since that one is based on ESLint - I'm not sure though,

@santoshyadavdev
Copy link
Contributor Author

@santoshyadavdev , you can add the migration if you want (as a separate commit, or in another PR). I don't think you can reuse the code, since that one is based on ESLint - I'm not sure though,

Cool will raise another PR once I am back from vacation, I mean I can get some idea from the lint.

@santoshyadavdev santoshyadavdev marked this pull request as ready for review October 19, 2021 12:18
@markostanimirovic markostanimirovic changed the title docs(store): depreate createFeatureSelector with state docs(store): deprecate createFeatureSelector with state Oct 19, 2021
@markostanimirovic markostanimirovic merged commit a6fe92d into ngrx:master Oct 20, 2021
@markostanimirovic markostanimirovic changed the title docs(store): deprecate createFeatureSelector with state docs(store): deprecate createFeatureSelector with root state Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the RootState generic of createFeatureSelector
4 participants