Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): use Record as Store generic #3158

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This change should help for cases as #2780 (comment).
This change doesn't fix the cases where createFeatureSelector is used with 2 generics.
To resolve those cases, we could assert the generic T as any, or remove the <State, FeatureState> overload from createFeatureSelector in the next version.

export const selectBooksState = createFeatureSelector<State, BooksState>(
  booksFeatureKey
);

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 1, 2021

Preview docs changes for 0092dd1 at https://previews.ngrx.io/pr3158-0092dd10/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants