Skip to content

Commit

Permalink
Fixed HashClient.{get,set}_many() with UNIX sockets.
Browse files Browse the repository at this point in the history
Overlooked when UNIX socket support was added to `HashClient` in
acd962b.

Fixes pinterest#314.
  • Loading branch information
ngnpope committed May 7, 2021
1 parent 9e2451a commit 1c46d5d
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 4 deletions.
13 changes: 9 additions & 4 deletions pymemcache/client/hash.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ def _get_client(self, key):
return
raise MemcacheError('All servers seem to be down right now')

client = self.clients[server]
return client
return self.clients[server]

def _safely_run_func(self, client, func, default_val, *args, **kwargs):
try:
Expand Down Expand Up @@ -383,7 +382,10 @@ def set_many(self, values, *args, **kwargs):
client_batches[client.server][key] = value

for server, values in client_batches.items():
client = self.clients['%s:%s' % server]
if isinstance(server, six.string_types):
client = self.clients[server]
else:
client = self.clients['%s:%s' % server]

failed += self._safely_run_set_many(
client, values, *args, **kwargs
Expand All @@ -406,7 +408,10 @@ def get_many(self, keys, gets=False, *args, **kwargs):
client_batches[client.server].append(key)

for server, keys in client_batches.items():
client = self.clients['%s:%s' % server]
if isinstance(server, six.string_types):
client = self.clients[server]
else:
client = self.clients['%s:%s' % server]
new_args = list(args)
new_args.insert(0, keys)

Expand Down
54 changes: 54 additions & 0 deletions pymemcache/test/test_client_hash.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,20 @@ def make_client(self, *mock_socket_values, **kwargs):

return client

def make_unix_client(self, sockets, *mock_socket_values, **kwargs):
client = HashClient([], **kwargs)

for socket_, vals in zip(sockets, mock_socket_values):
c = self.make_client_pool(
socket_,
vals,
**kwargs
)
client.clients[socket_] = c
client.hasher.add_node(socket_)

return client

def test_setup_client_without_pooling(self):
client_class = 'pymemcache.client.hash.HashClient.client_class'
with mock.patch(client_class) as internal_client:
Expand All @@ -50,6 +64,30 @@ def test_setup_client_without_pooling(self):
assert kwargs['timeout'] == 999
assert kwargs['key_prefix'] == 'foo_bar_baz'

def test_get_many_unix(self):
pid = os.getpid()
sockets = [
'/tmp/pymemcache.1.%d' % pid,
'/tmp/pymemcache.2.%d' % pid,
]
client = self.make_unix_client(sockets, *[
[b'STORED\r\n', b'VALUE key3 0 6\r\nvalue2\r\nEND\r\n', ],
[b'STORED\r\n', b'VALUE key1 0 6\r\nvalue1\r\nEND\r\n', ],
])

def get_clients(key):
if key == b'key3':
return client.clients['/tmp/pymemcache.1.%d' % pid]
else:
return client.clients['/tmp/pymemcache.2.%d' % pid]

client._get_client = get_clients

result = client.set(b'key1', b'value1', noreply=False)
result = client.set(b'key3', b'value2', noreply=False)
result = client.get_many([b'key1', b'key3'])
assert result == {b'key1': b'value1', b'key3': b'value2'}

def test_get_many_all_found(self):
client = self.make_client(*[
[b'STORED\r\n', b'VALUE key3 0 6\r\nvalue2\r\nEND\r\n', ],
Expand Down Expand Up @@ -284,6 +322,22 @@ def test_noreply_set_many(self):
result = client.set_many(values, noreply=True)
assert result == []

def test_set_many_unix(self):
values = {
'key1': 'value1',
'key2': 'value2',
'key3': 'value3'
}

pid = os.getpid()
sockets = ['/tmp/pymemcache.%d' % pid]
client = self.make_unix_client(sockets, *[
[b'STORED\r\n', b'NOT_STORED\r\n', b'STORED\r\n'],
])

result = client.set_many(values, noreply=False)
assert result == ['key2']

def test_server_encoding_pooled(self):
"""
test passed encoding from hash client to pooled clients
Expand Down

0 comments on commit 1c46d5d

Please sign in to comment.