fix: do not use RxJS scheduler since this may flush the queue within the root zone #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // RxJS schedulers coalesce tasks and then flush the queue, which means our task might be scheduled | ||
| // within the root zone, and then all of the tasks (that were set up by developers in the Angular zone) | ||
| // will also be flushed in the root zone. | ||
| function observeOnPromise<T>() { |
There was a problem hiding this comment.
You can use mergeMap instead of creating new observable as you're already imported it:
mergeMap((value) => Promise.resolve(value))There was a problem hiding this comment.
Whoops, missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #199