Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ngneat/elf-requests does not support removing a single request cache by key. #515

Closed
HeathJared opened this issue Mar 15, 2024 · 1 comment · Fixed by #516
Closed

@ngneat/elf-requests does not support removing a single request cache by key. #515

HeathJared opened this issue Mar 15, 2024 · 1 comment · Fixed by #516
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@HeathJared
Copy link

Which @ngneat/elf-* package(s) are relevant/releated to the feature request?

No response

Description

The package @ngneat/elf-requests provides a function clearRequestsCache, but this function does not support passing in a key as the argument.

Proposed solution

Add a new operator deleteRequestsCache(key: CacheRecordKeys<S>) to delete an individual cache from the store by key.

Alternatives considered

Add an overload clearRequestsCache to provide the same functionality described above.

Do you want to create a pull request?

No
@NetanelBasal NetanelBasal added enhancement New feature or request good first issue Good for newcomers labels Mar 16, 2024
smnsht added a commit to smnsht/elf that referenced this issue Mar 23, 2024
@smnsht
feat: add support for removing a single request cache by key(ngneat#515)
7cd62ab 
New function 'deleteRequestsCache'

resolves ngneat#515
smnsht added a commit to smnsht/elf that referenced this issue Mar 23, 2024
@smnsht
feat: add support for removing a single request cache by key(ngneat#515)
0b61bb4 
new function 'deleteRequestsCache'

resolves ngneat#515
@smnsht smnsht mentioned this issue Mar 23, 2024
Merged
3 tasks
NetanelBasal pushed a commit that referenced this issue Mar 25, 2024
@smnsht
feature(requests): add support for removing a single request cache by…
9dbc51d 
… key(#515) (#516)

New function 'deleteRequestsCache'

resolves #515
@VasilyShelkov
Copy link

Am I right in thinking this never made it to the released elf-requests package ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for removing a single request cache by key(#515) smnsht/elf
3 participants
@HeathJared @NetanelBasal @VasilyShelkov