Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead connections do not seem to clean up, causing performance issue #237

Open
xpdota opened this issue Dec 25, 2021 · 2 comments
Open

Dead connections do not seem to clean up, causing performance issue #237

xpdota opened this issue Dec 25, 2021 · 2 comments

Comments

@xpdota
Copy link

xpdota commented Dec 25, 2021

Repro:

  1. Start ACT
  2. Enable OverlayPlugin WS under Stream/Local Overlay
  3. Make sure there are no errors. Everything should be working.
  4. Connect and disconnect something from the OverlayPlugin Websocket connection (preferably a hard disconnect with no chance for cleanup)
    You will start to see these:
[12/24/2021 10:30:45 PM] Warning: WSServer: Data sent while closing or after close. Ignoring. 
[12/24/2021 10:30:48 PM] Warning: WSServer: Data sent while closing or after close. Ignoring. 
[12/24/2021 10:30:48 PM] Warning: WSServer: Data sent while closing or after close. Ignoring. 
[12/24/2021 10:30:48 PM] Warning: WSServer: Data sent while closing or after close. Ignoring. 
[12/24/2021 10:30:48 PM] Warning: WSServer: Data sent while closing or after close. Ignoring. 
  1. Connect and disconnect a few more times. You'll start to see one message for each connection you closed, every time WS data would have been sent.
  2. If you do this enough, you may bump into the dreaded "Line parsing is 10 seconds behind" message and ACT must be closed to recover.
@ngld
Copy link
Owner

ngld commented Dec 27, 2021

Can you check if you're on OverlayPlugin 0.18.0 or later? I've fixed a related bug in 0.17.3: cbeb873

However, if this is still happening, Fleck isn't emitting an OnClose event for the closed connection which means that I'll have to check the connection state every time I'm about to send something which I'd rather avoid.

@xpdota
Copy link
Author

xpdota commented Dec 27, 2021

Yes, I am on 0.18.0.0.

sandtechnology pushed a commit to sandtechnology/OverlayPlugin that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants