Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "switch from warning to debug when upstream labels are empty (#724)" #781

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

This reverts commit d3f9f94.

The commit changed the level for all labels and not just upstream, but in any case, we don't want to suppress the warnings, we want to notify the user of the library that the labels are not configured correctly.

If for some reason the warning wants to be ignored, it's always possible to set the level on the client side.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome requested a review from a team as a code owner July 17, 2024 03:35
@github-actions github-actions bot added the bug An issue reporting a potential bug label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (95324ec) to head (91e9952).

Files Patch % Lines
collector/nginx_plus.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #781   +/-   ##
=====================================
  Coverage   3.86%   3.86%           
=====================================
  Files          5       5           
  Lines       1319    1319           
=====================================
  Hits          51      51           
  Misses      1268    1268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome added this to the v1.3.0 milestone Jul 17, 2024
@lucacome lucacome mentioned this pull request Jul 19, 2024
@lucacome lucacome enabled auto-merge (squash) July 24, 2024 16:19
@lucacome lucacome merged commit a997509 into main Jul 24, 2024
14 checks passed
@lucacome lucacome deleted the fix/warning branch July 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants