-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cache metrics for NGINX plus #540
Conversation
The lint check has failed, do I need to perform |
Yes, please do run |
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Done, fixed lint issues and rebased |
Hi @sheharyaar, thanks for contributing to this project! We can merge this PR as soon as the lint errors are fixed. I get these two errors when running
For the first error, just run For the 2nd error, it seems like the |
@sheharyaar ignore my last command, I was late to the trigger 😆 |
Thank you @sheharyaar ! 🎉 |
Gald to contribute, welcome ! |
Proposed changes
Fixes #522 and exposes cache metrics from NGINX Plus API.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide