This repository has been archived by the owner on May 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
ciarams87,
jjngx and
pleshakov
and removed request for
a team
February 22, 2022 23:49
ciarams87
suggested changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments re: resource limits
ciarams87
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this going in if you are confident the RBAC proxy limits won't cause an issue. We should update the resource limits for the controller manager pod though before releasing.
lucacome
changed the title
Update Operator SDK to v1.17.0
Update Operator SDK to v1.18.0
Mar 1, 2022
@ciarams87 tested the changes and everything works fine. In the meantime, v1.18.0 came out so I've added those changes. |
lucacome
force-pushed
the
chore/update-sdk-1.17.0
branch
from
March 1, 2022 04:11
2d91b24
to
eb803d4
Compare
jjngx
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SDK to v1.17.0 https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.17.0/ and v1.18.0 https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.18.0/