Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Update Operator SDK to v1.18.0 #205

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Update Operator SDK to v1.18.0 #205

merged 3 commits into from
Mar 1, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 22, 2022

@lucacome lucacome requested a review from a team February 22, 2022 23:49
@lucacome lucacome self-assigned this Feb 22, 2022
@lucacome lucacome requested review from ciarams87, jjngx and pleshakov and removed request for a team February 22, 2022 23:49
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 22, 2022
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments re: resource limits

Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this going in if you are confident the RBAC proxy limits won't cause an issue. We should update the resource limits for the controller manager pod though before releasing.

@lucacome lucacome changed the title Update Operator SDK to v1.17.0 Update Operator SDK to v1.18.0 Mar 1, 2022
@lucacome
Copy link
Member Author

lucacome commented Mar 1, 2022

@ciarams87 tested the changes and everything works fine. In the meantime, v1.18.0 came out so I've added those changes.

Copy link

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lucacome lucacome merged commit bb6bd18 into master Mar 1, 2022
@lucacome lucacome deleted the chore/update-sdk-1.17.0 branch March 1, 2022 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants