Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update parsing logic to handle variables with braces #66

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: update parsing logic to handle variables with braces #66

merged 1 commit into from
Aug 14, 2023

Conversation

sylwang
Copy link
Contributor

@sylwang sylwang commented Aug 14, 2023

Proposed changes

Address 43818 so that the user can use variables with braces in the nginx config file.

  • update lex.go to correctly parse variables like ${foo}
  • add an nginx.config file in testdata for a test case of variables with braces
  • add a test case in parse_test.go to ensure that the parser can correctly parse variables with braces
  • fix the "messy" test case in lex_test.go so that values separated by spaces are tokenized

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@sylwang sylwang requested a review from a team as a code owner August 14, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants