Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions in Helm job #906

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix permissions in Helm job #906

merged 2 commits into from
Jul 25, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

The helm job didn't have the permissions needed to push the chart to GHCR

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome self-assigned this Jul 24, 2023
@lucacome lucacome requested a review from a team as a code owner July 24, 2023 23:54
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 24, 2023
ciarams87
ciarams87 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 🚀

@lucacome lucacome enabled auto-merge (squash) July 25, 2023 15:47
@lucacome lucacome merged commit 9c669be into nginxinc:main Jul 25, 2023
@lucacome lucacome deleted the chore/fix-helm-permissions branch January 16, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @pleshakov @ciarams87