Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile variables #888

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix Makefile variables #888

merged 1 commit into from
Jul 19, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:
c52b4da added comments to variables in Makefile, which broke Makefile logic because the variable values got trailing space character.

Solution:

  • Remove the trailing space character for variables with comments
  • Update help-generation Makefile code to account that

Tests:
Manual. make, make build, make container, make create-kind-cluster ran successfully.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pleshakov
Fix Makefile variables
e9109b6 
Problem:
c52b4da added comments to variables in Makefile, which
broke Makefile logic because the variable values got trailing space
character.

Solution:
- Remove the trailing space character for variables with comments
- Update help-generation Makefile code to account that

Tests:
Manual. make, make build, make container, make create-kind-cluster
ran successfully.
@pleshakov pleshakov requested a review from a team as a code owner July 19, 2023 21:17
@github-actions github-actions bot added the bug Something isn't working label Jul 19, 2023
@pleshakov pleshakov mentioned this pull request Jul 19, 2023
Merged
6 tasks
@pleshakov pleshakov requested a review from lucacome July 19, 2023 21:52
@pleshakov pleshakov merged commit 0f02384 into nginxinc:main Jul 19, 2023
16 checks passed
@pleshakov pleshakov deleted the fix/makefile branch July 19, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pleshakov @lucacome @sjberman @kate-osborn