Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewListenerInvalidRouteKinds condition #799

Merged

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Jun 28, 2023

Proposed changes

Problem: The GatewayInvalidRouteKind conformance test expects the ResolvedRef/False/InvalidRouteKinds condition to be set on a Listener that specifies an invalid route kind.

Solution: Add a NewListenerInvalidRouteKinds condition which is used when a Listener specifies an invalid route kind

Testing: Ran the GatewayInvalidRouteKind conformance tests. TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_HTTPRoute_must_be_put_in_the_supportedKinds is now passing.

    --- FAIL: TestConformance/GatewayInvalidRouteKind (60.06s)
        --- FAIL: TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_no_supportedKinds (60.02s)
        --- PASS: TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_HTTPRoute_must_be_put_in_the_supportedKinds (0.00s)

NOTE: This PR does not address both failing tests, only the correct condition, as we currently do not support setting the SupportedKinds based on the listener. This will be fixed in a separate PR. See #690

Closes #774

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner June 28, 2023 11:19
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Jun 28, 2023
@ciarams87 ciarams87 force-pushed the fix/update-invalid-route-kind-condition branch from 13f5bc6 to 67d12d0 Compare June 28, 2023 16:29
@ciarams87 ciarams87 merged commit b322ce1 into nginxinc:main Jun 28, 2023
@ciarams87 ciarams87 deleted the fix/update-invalid-route-kind-condition branch June 28, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Set ResolvedRefs/False/InvalidRouteKinds on Listeners with Invalid Route Kinds
3 participants