Watch for Secrets (draft) #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Watch for secret updates Solves nginxinc#553 Solution: Watch for secret updates
sjberman
reviewed
Jun 20, 2023
| return generated | ||
| files = append(files, file.File{ | ||
| Content: generated, | ||
| Path: "/etc/nginx/conf.d/http.conf", |
There was a problem hiding this comment.
Let's either make this a const, or what if we updated our dataplane.Configuration to have an http section, and in the future we'd add a stream section, where each could contain their respective configs and file paths? That's probably out of scope for this, but maybe worth a ticket?
| } | ||
|
|
||
| func generateTLSCertPath(id dataplane.TLSCertID) string { | ||
| return "/etc/nginx/secrets/" + string(id) + ".pem" |
There was a problem hiding this comment.
prefix is probably worth a const
| for _, file := range files { | ||
| f, err := os.Create(file.Path) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create server config %s: %w", file.Path, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed to create server config %s: %w", file.Path, err) | |
| return fmt.Errorf("failed to create file %s: %w", file.Path, err) |
|
|
||
| _, err = f.Write(file.Content) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to write server config %s: %w", file.Path, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed to write server config %s: %w", file.Path, err) | |
| return fmt.Errorf("failed to write file %s: %w", file.Path, err) |
|
@pleshakov approach looks good to me. Nice work simplifying the relationship capturing 👍 |
|
closing this in favor of a new non-draft PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Watch for secret updates
Solves #553
Solution:
Watch for secret updates
NOTE: this PR is a prototype. Need your comments about the design. (Please ignore low level details).
Key design decisions:
We can further refactor the code to get rid of relationship.Capturer completely in favour of using the Graph as a single source of truth about relationships among the resources.
Before creating a PR, run through this checklist and mark each as complete.