Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables to makefile help and build-goreleaser target #740

Merged
merged 7 commits into from
Jul 14, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 9, 2023

Proposed changes

Adds the list of variables when printing the help and a new target for building the binary with GoReleaser

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Adds the list of variables when printing the help and a new target for
building the binary with GoReleaser
@lucacome lucacome requested a review from a team as a code owner June 9, 2023 22:22
@lucacome lucacome self-assigned this Jun 9, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 9, 2023
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@lucacome lucacome enabled auto-merge (squash) July 12, 2023 19:42
@lucacome lucacome merged commit c52b4da into nginxinc:main Jul 14, 2023
@lucacome lucacome deleted the chore/makefile branch July 18, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants