Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binding to multiple listeners with empty section name #730

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Jun 8, 2023

Proposed Changes

A refactor of the route binding logic done in #633 introduced a bug with empty section name. This PR fixes that bug.

Problem: If an HTTPRoute has a parentRef with an empty section name, and the referenced gateway has multiple valid listeners, the route would only bind to the first listener.

Solution: Attempt to bind to every valid listener in the referenced Gateway.

Testing: Added a unit test that reproduced the issue and manually verified that a route with empty section name can attach to multiple valid listeners.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: If an HTTPRoute has a parentRef with an empty section name,
and the referenced gateway has multiple valid listeners, the route would
only bind to the first listener.

Solution: Attempt to bind to every valid listener in the referenced Gateway.
@kate-osborn kate-osborn requested a review from a team as a code owner June 8, 2023 20:46
@github-actions github-actions bot added the bug Something isn't working label Jun 8, 2023
@kate-osborn kate-osborn merged commit e74a5c4 into nginxinc:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants