Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in required capabilities for writing TLS secrets #718

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: TLS termination is not working because the NGINX container is missing the DAC_OVERRIDE capability. This is required to bypass write permission checks on the files in /etc/nginx/secrets so we can write the TLS secrets to disk.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Closes #714

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner June 6, 2023 16:51
@github-actions github-actions bot added the bug Something isn't working label Jun 6, 2023
@kate-osborn kate-osborn self-requested a review June 6, 2023 17:32
@ciarams87 ciarams87 merged commit ebee362 into nginxinc:main Jun 7, 2023
@ciarams87 ciarams87 deleted the fix/nginx-caps branch June 7, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TLS termination doesn't work
5 participants