Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/run conformance tests #713

Merged
merged 22 commits into from
Jun 12, 2023
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 5, 2023

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Ability to run gateway api conformance tests locally on KinD cluster.

Solution: Run tests in a container with the help of provided make commands.

Testing: Build the test runner image and execute tests

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #648

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Jun 5, 2023
@vepatel
Copy link
Contributor Author

vepatel commented Jun 5, 2023

in-progress, seems like there's an issue with provisioner. @pleshakov is taking a look to confirm.

@pleshakov
Copy link
Contributor

{“level”:“info”,“ts”:“2023-06-05T17:26:04Z”,“logger”:“eventLoop”,“msg”:“added an event to the next batch”,“type”:“*events.UpsertEvent”,“total”:1}
panic: failed to create deployment: Deployment.apps “nginx-gateway-gateway-conformance-infra-same-namespace-with-http-listener-on-8080" is invalid: [spec.selector.matchLabels: Invalid value: “nginx-gateway-gateway-conformance-infra-same-namespace-with-http-listener-on-8080”: must be no more than 63 characters, spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{“app”:“nginx-gateway-gateway-conformance-infra-same-namespace-with-http-listener-on-8080”}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: invalid label selector]

when creating a deployment, the generated labels are too long -- I will prepare a fix

@pleshakov
Copy link
Contributor

Added a different bug -- #714 -- which is also a blocker

This one prevented one of base Gateways to become Programmed in the status, because NGINX will fail to reload.

@vepatel vepatel marked this pull request as ready for review June 6, 2023 15:08
@vepatel vepatel requested a review from a team as a code owner June 6, 2023 15:08
conformance-tests/Makefile Outdated Show resolved Hide resolved
conformance-tests/README.md Outdated Show resolved Hide resolved
@vepatel vepatel requested review from lucacome and sjberman June 7, 2023 12:17
conformance-tests/Makefile Outdated Show resolved Hide resolved
@vepatel vepatel requested a review from sjberman June 7, 2023 14:27
conformance-tests/README.md Outdated Show resolved Hide resolved
conformance-tests/README.md Outdated Show resolved Hide resolved
conformance-tests/conformance_test.go Outdated Show resolved Hide resolved
@vepatel vepatel requested a review from kate-osborn June 8, 2023 11:22
conformance-tests/conformance_test.go Outdated Show resolved Hide resolved
conformance-tests/Dockerfile Outdated Show resolved Hide resolved
conformance-tests/README.md Outdated Show resolved Hide resolved
conformance-tests/conformance_test.go Outdated Show resolved Hide resolved
docs/developer/testing.md Outdated Show resolved Hide resolved
conformance-tests/Makefile Outdated Show resolved Hide resolved
conformance-tests/README.md Outdated Show resolved Hide resolved
@vepatel vepatel requested a review from pleshakov June 9, 2023 16:37
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @vepatel
I found a few issues. but looks good otherwise

conformance/README.md Outdated Show resolved Hide resolved
conformance/tests/conformance_test.go Outdated Show resolved Hide resolved
conformance-tests/Makefile Outdated Show resolved Hide resolved
@vepatel vepatel requested a review from pleshakov June 12, 2023 14:24
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vepatel vepatel merged commit 6aaefb3 into nginxinc:main Jun 12, 2023
@vepatel vepatel deleted the tests/run-conformance-tests branch June 12, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Local conformance tests
5 participants