Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTPRoute section name related bugs #568

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Commits on Apr 10, 2023

  1. Fix section name related bugs

    - Previously, NKG assumed section names in parentRefs of HTTPRoute
    were unique, even when they referenced different Gateways. This
    commit fixes that. Fixes #484
    - Previously, when NKG reported status for a parentRef with an empty
    section name, it would give the ref the name "unattached" in
    the HTTPRoute status. This behavior is not Gateway API spec compliant --
    the API prescribe to use empty section name in that case. Now NKG
    will use empty section name. See the corresponding
    FIXME in the code https://github.com/nginxinc/nginx-kubernetes-gateway/blob/b594695bb42a79653eb8217a6dfd00c6d9594d5b/internal/state/statuses.go#L151
    Note: the FIXME advice is wrong.
    - Previously, in case of multiple parentRefs in an HTTPRoute, when
    reporting their statuses in the HTTPRoute status, NKG could change
    the order of the refs in the status. This commit restores the order.
    See the corresponding FIXME in
    the code https://github.com/nginxinc/nginx-kubernetes-gateway/blob/b594695bb42a79653eb8217a6dfd00c6d9594d5b/internal/status/httproute.go#L25
    pleshakov committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    b134179 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Improve unit test

    pleshakov committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e0a11a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6687043 View commit details
    Browse the repository at this point in the history