Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant warnings #502

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Remove redundant warnings #502

merged 1 commit into from
Mar 23, 2023

Conversation

pleshakov
Copy link
Contributor

The warnings reported by dataplane.BuildConfiguration() are now redundant - they are reported as Conditions in the statuses of Gateway API resources, which includes warnings-related cases for:

  • invalid listener in an HTTPRoute
  • unresolved backend ref an HTTPRoute

This PR removes the code, which generates and reports warnings.

Additionally, the PR fixes a related test TestBuildConfiguration case "invalid listener": if a listener is invalid, it cannot include any Routes and AcceptedHostnames, so those fields are removed.

Fixes #467

The warnings reported by dataplane.BuildConfiguration() are now
redundant - they are reported as Conditions in the statuses of
Gateway API resources, which includes warnings-related cases for:
* invalid listener in an HTTPRoute
* unresolved backend ref an HTTPRoute

This commit removes the code, which generates and reports warnings.

Additionally, the commit fixes a related test TestBuildConfiguration
case "invalid listener": if a listener is invalid, it cannot include
any Routes and AcceptedHostnames, so those fields are removed.

Fixes #467
@pleshakov pleshakov requested a review from a team as a code owner March 23, 2023 18:36
@github-actions github-actions bot added the enhancement New feature or request label Mar 23, 2023
@pleshakov pleshakov merged commit c9d912c into main Mar 23, 2023
@pleshakov pleshakov deleted the enhancement/remove-warnings branch March 23, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove redundant warnings
2 participants